Skip to content

Add simulator package #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Oct 28, 2025
Merged

Add simulator package #247

merged 21 commits into from
Oct 28, 2025

Conversation

@andrew-fleming
Copy link
Contributor

@andrew-fleming andrew-fleming commented Sep 15, 2025 •
edited
Loading

Types of changes

What types of changes does your code introduce to OpenZeppelin Midnight Contracts?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
    • breaking current testing structure and empty witness format

Fixes #???

PR Checklist

  • I have read the Contributing Guide
  • I have added tests that prove my fix is effective or that my feature works
  • I have added documentation of new methods and any new behavior or changes to existing behavior
  • CI Workflows Are Passing

Overview

WIP

@andrew-fleming andrew-fleming mentioned this pull request Sep 26, 2025
Merged
0xisk
0xisk reviewed Oct 9, 2025
View reviewed changes
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR really adds a lot of improvements for the testing framework. This is not a complete review. Wondering what is left for this PR to be open?

packages/simulator/package.json Outdated
@@ -0,0 +1,42 @@
{
"name": "@openzeppelin-compact/simulator",
Copy link
Member

@0xisk 0xisk Oct 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "@openzeppelin-compact/simulator",
"name": "@openzeppelin-compact/contracts-simulator",

I was thinking that should be more specific, as in the suggestion.

Copy link
Contributor Author

@andrew-fleming andrew-fleming Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to contracts-simulator

Copy link
Member

@0xisk 0xisk Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes that is better, Compact is already there.

@andrew-fleming
Copy link
Contributor Author

andrew-fleming commented Oct 10, 2025

This PR really adds a lot of improvements for the testing framework. This is not a complete review. Wondering what is left for this PR to be open?

@0xisk Thank you! I just needed to add some fixes so the CI would not fail. All good now

@andrew-fleming andrew-fleming marked this pull request as ready for review October 10, 2025 07:10
@andrew-fleming andrew-fleming requested a review from a team as a code owner October 10, 2025 07:10
emnul
emnul reviewed Oct 23, 2025
View reviewed changes
emnul
emnul reviewed Oct 23, 2025
View reviewed changes
emnul
emnul reviewed Oct 23, 2025
View reviewed changes
@emnul
Copy link
Contributor

emnul commented Oct 23, 2025

@andrew-fleming could you add more context regarding the purpose of the fixtures folder? Perhaps another README.md file in the test folder?

@andrew-fleming
Copy link
Contributor Author

andrew-fleming commented Oct 23, 2025 •
edited
Loading

could you add more context regarding the purpose of the fixtures folder? Perhaps another README.md file in the test folder?

@emnul on it! And done d2b4f80

andrew-fleming and others added 3 commits October 23, 2025 12:05
@andrew-fleming andrew-fleming mentioned this pull request Oct 27, 2025
Closed
2 tasks
0xisk
0xisk reviewed Oct 27, 2025
View reviewed changes
packages/simulator/test/fixtures/test-artifacts/SampleZOwnable/compiler/contract-info.json
Copy link
Member

@0xisk 0xisk Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to not push the test-artifacts, and instead compile the sample-contracts before testing and get the output on /test-artifacts directory?

0xisk
0xisk requested changes Oct 27, 2025
View reviewed changes
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andrew-fleming, I just have one comment, and then it will be good to go.

@0xisk 0xisk mentioned this pull request Oct 27, 2025
Open
0xisk
0xisk approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @andrew-fleming LGTM!

@emnul emnul merged commit 85fab88 into OpenZeppelin:main Oct 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emnul emnul emnul approved these changes

@0xisk 0xisk 0xisk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrew-fleming @emnul @0xisk